Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: card cvc bug fix #748

Merged
merged 3 commits into from
Oct 25, 2024
Merged

fix: card cvc bug fix #748

merged 3 commits into from
Oct 25, 2024

Conversation

Sanskar2001
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

  • Recently a merchant reported that user was not able to enter 4 digit cvc which was caused by cobadged cards support feature.
  • Also an existing bug was there even before cobadged card support feature was merged. When user enters a 4 digit card in card form and then navigates to saved cards screen then the user can enter 4 digit cvc even for cards which only supports 4 digit cvc. Attaching a video of this bug and fixed this issue in this PR.
  • Added test case for cvc checks, so that this doesn't happen again in future.
Screen.Recording.2024-10-22.at.8.22.50.PM.mov

How did you test it?

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Oct 23, 2024 •
edited
Loading

Review changes with SemanticDiff.

Analyzed 2 of 4 files.

Filename Status
❔ src/CardUtils.res Unsupported file format
❔ src/Payment.res Unsupported file format
✔️ cypress-tests/cypress/support/utils.ts Analyzed
✔️ cypress-tests/cypress/e2e/cvc-checks-e2e-test.cy.ts Analyzed

PritishBudhiraja
PritishBudhiraja reviewed Oct 23, 2024
View reviewed changes
src/CardUtils.res Outdated Show resolved Hide resolved
@PritishBudhiraja PritishBudhiraja added the Ready for Review PR with label Ready for Review should only be reviewed. label Oct 23, 2024
PritishBudhiraja
PritishBudhiraja reviewed Oct 25, 2024
View reviewed changes
src/CardUtils.res Outdated Show resolved Hide resolved
PritishBudhiraja
PritishBudhiraja reviewed Oct 25, 2024
View reviewed changes
src/Payment.res Outdated Show resolved Hide resolved
PritishBudhiraja
PritishBudhiraja approved these changes Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@PritishBudhiraja PritishBudhiraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PritishBudhiraja PritishBudhiraja merged commit 6122d9d into main Oct 25, 2024
4 checks passed
@PritishBudhiraja PritishBudhiraja deleted the cvc-bug-fix branch October 25, 2024 07:26
@github-actions github-actions bot added Closed Label will be automatically added when the PR will get merged to main and removed Ready for Review PR with label Ready for Review should only be reviewed. labels Oct 25, 2024
PritishBudhiraja pushed a commit that referenced this pull request Oct 25, 2024
@semantic-release-bot
chore(release): 0.96.1 [skip ci]
627980d 
## [0.96.1](v0.96.0...v0.96.1) (2024-10-25)

### Bug Fixes

* card cvc bug fix ([#748](#748)) ([6122d9d](6122d9d))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PritishBudhiraja PritishBudhiraja PritishBudhiraja approved these changes

@seekshiva seekshiva Awaiting requested review from seekshiva seekshiva is a code owner

@ArushKapoorJuspay ArushKapoorJuspay Awaiting requested review from ArushKapoorJuspay ArushKapoorJuspay is a code owner

Assignees

@Sanskar2001 Sanskar2001

Labels
Closed Label will be automatically added when the PR will get merged to main
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sanskar2001 @PritishBudhiraja